Making the function arguments more idiomatic; move everything to one package #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings to pass arguments, but rather a struct. Moved all the files to the same package, created some tests as well. Need to write more tests, and change a lot more code to be more idomatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a map of strings as the argument for Generate, Base64String, and URIimage seems like an anti-pattern in Go (It would be the right thing to do in Javascript). A more idiomatic approach would be to use a Struct. This change breaks reverse compatibility with this library.
I also moved all the sub-packages into the geopattern package. If this is a problem, I can try and make it work with the sub-packages.