-
Notifications
You must be signed in to change notification settings - Fork 86
Allow bigdecimal v4 #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow bigdecimal v4 #108
Conversation
|
@pointlessone please review - now that bigdecimal 4.0.x is released, ttfunk 1.8.0's dependency on bigdecimal |
|
I think it's safe to use v4 instead of v3 BigDecimal in this gem. At least it doesn't make things worse, because only the class is expected and that these numbers respond to |
|
I'm delighted about all the activity. But I'm a bit in a pickle. Today I only had 2 hours of power, yesterday—4. And it doesn't look like I'm suddenly gonna have much more in the coming days. Once the situation becomes a little bit more predictable I'll look into it. The main concern for this particular issue is that I haven't decided what Rubies to support for the next release. IIRC, I said the last release would be the last to support 2.7 but uh… Barely any Rubies of the last release are still supported. It might be a bit of stretch to have a release with a sudden huge jump in minimum Ruby version. So I'll have to look closer into that. But again, once things settle a bit. No time frame at the moment but I want to do it relatively soon, as circumstances allow. |

See https://github.com/ruby/bigdecimal/blob/master/CHANGES.md