Move native build logic to a Kotlin class. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change but removes some cruft from the openjdk build.gradle. BoringSSL build directory is still a bit of a hack but I'll address that in a later, smaller PR.
prbprbprb
force-pushed
the
02_native_build
branch
from
8e46d1c to
dba4a75
Compare
google#1394) * Update serialization tests to handle class name length and potential EOFException. Adjusts the expected hex encoding in EdDSA key serialization tests to dynamically include the length of the class name. Also, modifies invalid key deserialization tests in both EdDSA and ML-DSA to catch both `IllegalArgumentException` and `EOFException`, as either can occur during parsing of malformed serialized data. Test: atest EdDsaTest/MlDsaTest * Update MlDsaTest.java
Owner
Author
|
Submitted upstream at google#1388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change but removes some cruft from
the openjdk build.gradle.
BoringSSL build directory is still a bit of a hack but I'll address that in a later, smaller PR.