Mrege dev to master and create 2.1 release #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from address 3, but P3-ROC is bits 11:8, and P-ROC is bits 7:4.
Can now actually set these with the -D command line option.
Quiets a compiler warning, and matches the `file_board_id` declaration.
When building in MSYS2/MinGW64, I was missing multiple DLLs necessary to run the EXE files from a command prompt.
Previously we'd fail to call PRDelete(), which may have been causing some of my problems with attempting to re-connect to the P-ROC. I assume PRDelete() closes out the connection in some way.
# Conflicts: # CMakeLists.txt
This reverts commit d681054.
This reverts commit 69bd547.
Merge outstanding commits to `dev`
`pinproctest` now takes machineType as it's command-line parameter.
Compiler warnings showed we were overflowing arrays sized for kPRDriverGroupsMax.
`combinedVersionRevision` is a 32-bit value. This API isn't exposed in the public pinproc.h header, so it's safe to make this change.
Expose some useful values for code that interfaces with libpinproc.
Includes check to limit accelerometer-related code to P3-ROC since it fails on the P-ROC (which doesn't have an accelerometer).
Added for yaml-cpp, which is no longer a dependency for pinproctest.
This is a reasonable requirement. It allows removal of two OLD policies and gives us consistent behavior for relative link directories.
While case-insensitive compare of the machine type passed on the command line would be nice, the function to do so has different names on different platforms, and its behavior may be impacted by the user's locale setting.
By setting stdout to unbuffered, the user always sees our output and we can eliminate the fflush() calls sprinkled throughout the programs.
Contributor
Author
|
Thoughts, @gstellenberg @jabdoa2 @preble ? Maybe if I can get a P3-ROC and resolve the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At what point is it safe to merge
devback tomasterand tag a release?I made a lot of changes to dev, including cleaning up code, merging a
pinprocfwbug on P3, adding a feature used in MPF and removing theyaml-cppdependency.