Mongo import #13
Mongo import #13
Conversation
Change collections to use streamTs
add configuration via mongodb
add org to build.sbt
tools/import/jdbc/build.sbt
Outdated
There was a problem hiding this comment.
This should probably be updated to 1.0.0-M7.7 - there are a ton of bugfixes since M6
There was a problem hiding this comment.
This suggests the presence of an ImportMongo shell/bat script, which is isn't found on this PR. It might be worthwhile to explain what each parameter looks like as well, as the person doing this might not be familiar with mongo, assuming he uses it through some other tool, and is probably not familiar with precog.
For example, it is not immediately obvious that you want/need your accountId on the path, whereas an example would make that clear.
…nto MongoImport Conflicts: tools/import/jdbc/src/main/scala/com/precog/tools/importers/jdbc/ImportJdbc.scala
tools/import/common/build.sbt
Outdated
There was a problem hiding this comment.
I'd leave off the explicit scalaz dependency here and use the transitive dep from blueeyes.
There was a problem hiding this comment.
Why go via iterator at all? Just have an inner tailrec method that builds the list then reverses it at the end.
|
pushed my changes |
No description provided.