Add PredicateHolding Contract #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 4
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
penDerGraft
requested review from
Jesse-Sawa,
balesandrew,
ning-an and
patrickdappollonio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new contract to the inheritance examples called
PredicateHolding. This is for initial integration with the Predicate API when a full onchain integration is either not ready or not feasible.This PR also fixes a few bugs in the release workflow.
Note
Introduces a simple inheritance-based contract and strengthens artifact generation and publishing.
PredicateHolding.sol(inheritance pattern) storing Predicate config with owner-managedsetPolicyID/setRegistry; docs updated insrc/examples/README.md.release-artifacts.yml): determine workflow branch vs tag, checkout workflow branch to fetch script, cache script to/tmp, then checkout code at tag; useGH_TOKEN; simplify uploads with--clobberand stable asset paths (Contract/File), add stricter failure on zero uploads, and cleanup temp assets.scripts/extract-artifacts.js): supportsPredicateHoldingand proxy contract, generates Standard JSON input and separate compiler settings for verification, writes compiler metadata once, records per-contract source metadata, handles inheritance output paths, logs bytecode hash, and prints an artifact summary.Written by Cursor Bugbot for commit 40eb7b1. This will update automatically on new commits. Configure here.