feat: update default windows compiler#2136
Conversation
|
The error comes from upstream |
|
Hey @Glatzel I am not sure if we should really edit this ... I have asked on Zulip: |
|
Hi @wolfv, I agree with removing the default bahavior of parsing But, it needs decision, if you think If you decide to apply the no default compiler solution, just close this pr. I may try it to remove those compiler relate code and revise the doc. It could effect many tests and need some time, so no guarentee here. |
Update default Windows compilers to match conda-forge pinning: - C/C++: vs2017 → vs2022 - Fortran: gfortran → flang (on Windows) References: conda-forge/conda-forge-pinning-feedstock Co-Authored-By: Glatzel <chenzelin9794@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wolfv
force-pushed
the
update-win-compiler
branch
from
d7707fe to
64c7e1d
Compare
|
The doc is generated by ai, but I have reviewed and revised it. |
|
Will check this out @Glatzel as soon as CI is green. Please ping me sometime next week if I don't get to it :) |
test/end-to-end/conftest.py
Outdated
| @pytest.fixture | ||
| def clean_path_on_win32(): | ||
| # On Windows, clear path to avoid hitting the cmd.exe | ||
| # line-length limit during VS compiler activation (vcvars64.bat). | ||
| if sys.platform == "win32": | ||
| original_path = os.environ.get("PATH", "") | ||
| try: | ||
| os.environ["PATH"] = "" | ||
| yield | ||
| finally: | ||
| os.environ["PATH"] = original_path | ||
| else: | ||
| yield | ||
|
|
||
|
|
||
| def pytest_configure(config): | ||
| # On Windows, use a short absolute path to avoid hitting the cmd.exe | ||
| # line-length limit during VS compiler activation (vcvars64.bat). | ||
| if sys.platform == "win32": | ||
| worker_id = os.environ.get("PYTEST_XDIST_WORKER", "bld").replace("gw", "") | ||
| config.option.basetemp = Path(f"C:/{worker_id}") |
There was a problem hiding this comment.
@baszalmstra can you please take a look if this makes sense to you?
try revert pytest ini
3 participants
references:
fix: #2340