Avoid deprecated function and allow more than 100 sites#1
Open
abertranb wants to merge 1 commit intopressjitsu:masterfrom
Open
Avoid deprecated function and allow more than 100 sites#1abertranb wants to merge 1 commit intopressjitsu:masterfrom
abertranb wants to merge 1 commit intopressjitsu:masterfrom
Conversation
|
Thank you. Can you please conform to WPCS for the patch? We'll gladly merge this. |
Author
|
The WPCS woths with Python files? |
|
It's a PHP file you altered, no? :) |
Author
|
Yes , but I can perform the check in python file. I don't know how Bests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi the code uses wp_get_sites() and is deprecated, also won't work with large multisite instance (more than 100 sites)
Best regards and thanks for sharing!