Draft
Conversation
Contributor
|
Analysis seems reasonable to me. One note: function names are referenced by gUnknown_086AD4C4 in the rom_2.s file, and those would likely need to be updated to match the assigned function names here before this would compile. Also, for context, sub_19B90 gets called by both the ruby/sapphire board. While most of the functions in the respective board_process3_[...] files matches only a single board, both end up calling this, and therefore, the substate init/loop functions defined by the arrays at gUnknown_086AD4C4 and gUnknown_086AD4E8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document states of the two main boards. This includes:
Currently a work in progress.
Discord username
zenonx