Skip to content

Adds a node legacy container #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adds a node legacy container #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
548aa8c
Adds a node legacy container
kimpepper Oct 1, 2020
a1a76f2
Adds node-legacy container
kimpepper Oct 1, 2020
9ee59ca
Ignore pinned versions
kimpepper Oct 1, 2020
7149e35
Use skpr base image
kimpepper Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ dirs: &dirs
- mailhog
- passenger
- node
- node-legacy
- php-apache
- pnx-packager
- sftp
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.idea/
2 changes: 2 additions & 0 deletions node-legacy/.hadolint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ignored:
- DL3018
11 changes: 11 additions & 0 deletions node-legacy/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
ARG VERSION=10
FROM skpr/node:${VERSION}

USER root

RUN apk add --no-cache \
ruby \
ruby-dev \
ruby-bundler

USER skpr
32 changes: 32 additions & 0 deletions node-legacy/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
#!/usr/bin/make -f

IMAGE=previousnext/node-legacy

define buildimage
docker build --build-arg VERSION=$(1) -t $(IMAGE):$(1) .
endef

define pushimage
docker push $(IMAGE):$(1)
endef

build: build10 build12 build14

lint:
hadolint Dockerfile

build10:
$(call buildimage,10-1.x)

build12:
$(call buildimage,12-1.x)

build14:
$(call buildimage,14-1.x)

push: build
$(call pushimage,10-1.x)
$(call pushimage,12-1.x)
$(call pushimage,14-1.x)

.PHONY: *