Open
Conversation
MaeIsBad
reviewed
Sep 28, 2023
Member
MaeIsBad
left a comment
MaeIsBad
left a comment
There was a problem hiding this comment.
The problem with doing this is we won't have our CI test for changes with anything but the latest version, which might lead to us accidentally breaking support for older versions. We could relax the version policy and declare that compatibility with versions other than 1.0 is provided on a best-effort basis but that might result in people using an unsupported combination of libraries without realizing it.
Can you elaborate about why you're unable to update your joken version? I'm not opposed to doing this, but I would prefer not to end up breaking stuff on accident
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Relaxing joken_jwks version spec would reduce dependency conflict surface.
Best,
Yevhenii