feat: Support big-decimal as well as big_decimal #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpiemontese
previously approved these changes
Oct 22, 2025
Contributor
cpiemontese
left a comment
cpiemontese
left a comment
There was a problem hiding this comment.
👍 for me, but what is big_decimal with the _ even for...?
Contributor
|
Could you update the CHANGELOG too? |
Contributor
Author
|
Sorry, @cpiemontese, I was just adding some tests to check this actually works ;)
I've no idea, but I have to assume that someone might be using it! |
cpiemontese
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec has
big-decimal, see: https://avro.apache.org/docs/++version++/specification/#decimal.I believe that this PR will add support for
big-decimalwhile maintaining backwards compatibility forbig_decimal.