ci: allow PRs to run from external contributions #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpatoio
reviewed
May 29, 2025
| concurrency: | ||
| group: ci-${{ github.head_ref || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
Contributor
Author
There was a problem hiding this comment.
That's to avoid running multiple CIs for the same pull requests, older ones will get cancelled if a new one is started
(See here)
hpatoio
previously approved these changes
May 29, 2025
MaeIsBad
reviewed
May 30, 2025
Member
MaeIsBad
left a comment
MaeIsBad
left a comment
There was a problem hiding this comment.
How does this fix the issue?
Contributor
Author
|
My initial thought was that CI wasn't run at all since if you look at the external contribution there's nothing to "approve & run", but maybe that's not it...? Anyway, I think the workflow is still better even if it doesn't fix the issue |
Member
|
right yeah I think you're right and the on trigger is just wrong |
MaeIsBad
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we made it so external contributions' workflows wouldn't run, but reading here first time contributors still need to be approved so there shouldn't be any security issues (see here on Slack for confirmation from security)