use-styled-react-import: add theme components #426
Merged
+164
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthkp
requested review from
Copilot and
pksjce
and removed request for
Copilot
🦋 Changeset detectedLatest commit: 4325bde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
13 tasks
13 tasks
Add ThemeProvider, BaseStyles, and useTheme to allow theme components to be imported from styled-react without sx.
siddharthkp
requested review from
francinelucca
and removed request for
pksjce
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the use-styled-react-import ESLint rule to handle theme-related components and utilities. The change allows ThemeProvider and BaseStyles components to always be imported from @primer/styled-react regardless of whether they use the sx prop, and adds useTheme utility to the list of items that should be imported from styled-react.
- Added
ThemeProvider,BaseStyles, anduseThemeto respective component/utility lists - Created exemption logic for theme components that should always come from styled-react
- Refactored the autofix logic to handle batch operations when moving multiple imports
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/rules/use-styled-react-import.js | Core rule implementation with new theme component handling and improved autofix logic |
| src/rules/tests/use-styled-react-import.test.js | Comprehensive test cases covering new theme component behaviors |
| .changeset/short-pumas-kneel.md | Changeset documentation for the minor version update |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
francinelucca
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.