-
Notifications
You must be signed in to change notification settings - Fork 638
Remove support for sx
from ActionList
component and sub-components
#6906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa08f12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…6861) Co-authored-by: Marie Lucca <francinelucca@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Co-authored-by: Marie Lucca <francinelucca@github.com> Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes> Co-authored-by: Marie Lucca <francinelucca@github.com>
…6868) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…the vitest group (#6916) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6757
Closes https://github.com/github/primer/issues/5908
Closes #6774
Current
sx
usage: 7✅
sx
usages are only in repos other than github-ui; those usages have been added to the tracking issueNavList
component is dependent on this one. Need to wait forsx
removal to be completed there before proceeding. Issue: #6768 PR: #6868Changelog
Removed
Remove support for
sx
from theActionList
component, and any sub-components, associated stories, docs, and testsRollout strategy
This component currently has 0
sx
usage in dotcom, and therefore does not need the @primer/styled-react wrapper. this will be confirmed again before merging.Merge checklist