Skip to content

Upgrade eslint-plugin-primer-react to v8.4.0 and enable spread-props-first rule: warn #7071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Upgrade eslint-plugin-primer-react to v8.4.0 and enable spread-props-first rule: warn #7071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f4c7b83
Initial plan
Copilot Oct 24, 2025
16ed810
Initial commit - planning upgrade of eslint-plugin-primer-react
Copilot Oct 24, 2025
a4ddb52
Upgrade eslint-plugin-primer-react to v8.4.0 and enable spread-props-…
Copilot Oct 24, 2025
0469266
Change spread-props-first to warn and revert all auto-fixes
Copilot Oct 27, 2025
b80a384
Add eslint-disable comments for spread-props-first warnings
Copilot Oct 27, 2025
c9bbf7f
Remove eslint-disable comments and remove --max-warnings from lint co…
Copilot Oct 27, 2025
78870c8
trying out conditional rule
siddharthkp Oct 27, 2025
9761da8
bring back --max-warnings=0
siddharthkp Oct 27, 2025
5dfd832
Revert "trying out conditional rule"
siddharthkp Oct 27, 2025
d754263
Revert "Remove eslint-disable comments and remove --max-warnings from…
siddharthkp Oct 27, 2025
f6d5c58
Reapply "Remove eslint-disable comments and remove --max-warnings fro…
siddharthkp Oct 27, 2025
bc83be9
remove --max-warnings
siddharthkp Oct 27, 2025
2d9729f
Merge branch 'main' into copilot/upgrade-eslint-plugin-primer-react
siddharthkp Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ const config = defineConfig([
'primer-react/a11y-use-next-tooltip': 'error',
'primer-react/no-unnecessary-components': 'error',
'primer-react/prefer-action-list-item-onselect': 'error',
'primer-react/spread-props-first': 'warn',
},
},

Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"build:docs:preview": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs preview",
"build:components.json": "npm run build:components.json -w @primer/react",
"build:hooks.json": "npm run build:hooks.json -w @primer/react",
"lint": "eslint '**/*.{js,ts,tsx,md,mdx}' --max-warnings=0 --cache",
Copy link
Member

@siddharthkp siddharthkp Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer: This is the only bad part about making the rule "warn" instead of "error". We open up warnings from other rules as well because there is no way to allow warnings from one rule.

"lint": "eslint '**/*.{js,ts,tsx,md,mdx}' --cache",
Copy link
Member

@siddharthkp siddharthkp Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer:

We could add a number here which matches the current number of warnings for this one rule, but then we also have to keep it updated any time we fix a warning so that other warnings don't sneak into the gap

Suggested change
"lint": "eslint '**/*.{js,ts,tsx,md,mdx}' --cache",
"lint": "eslint '**/*.{js,ts,tsx,md,mdx}' --max-warnings=321 --cache",

"lint:css": "stylelint --rd -q --cache '**/*.css'",
"lint:css:fix": "npm run lint:css -- --fix",
"lint:fix": "npm run lint -- --fix",
Expand Down Expand Up @@ -70,7 +70,7 @@
"eslint-plugin-mdx": "3.6.2",
"eslint-plugin-playwright": "^2.2.2",
"eslint-plugin-prettier": "^5.5.4",
"eslint-plugin-primer-react": "^8.2.0",
"eslint-plugin-primer-react": "^8.4.0",
"eslint-plugin-react": "^7.35.5",
"eslint-plugin-react-compiler": "^19.1.0-rc.2",
"eslint-plugin-react-hooks": "^5.2.0",
Expand Down
Loading