Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contributor-docs/adrs/adr-009-behavior-isolation.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,4 +208,4 @@ Organizational overhead of shared dependencies is something that we will have to
## Consequences

- By using `@lit-labs/ssr` today, we introduce a new dependency into Primer React. This may be removed later should React support Custom Elements out of the box (which seems likely for React 19), but for now we will need to continue to ship this dependency.
- This decision may expediate the need to resolve organisational overhead issues. Deciding to use custom elements to share more code among PVC and PRC may highlight other areas which need to be addressed in subsequent PRs.
- This decision may expedite the need to resolve organisational overhead issues. Deciding to use custom elements to share more code among PVC and PRC may highlight other areas which need to be addressed in subsequent PRs.
2 changes: 1 addition & 1 deletion packages/react/src/KeybindingHint/key-names.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const accessibleKeyName = (key: string, isMacOS: boolean) =>
printscreen: 'print screen',
// We don't need to represent _every_ symbol - only those found on standard keyboards.
// Other symbols should be avoided as keyboard shortcuts anyway.
// These should match the colloqiual names of the keys, not the names of the symbols. Ie,
// These should match the colloquial names of the keys, not the names of the symbols. Ie,
// "Equals" not "Equal Sign", "Dash" not "Minus", "Period" not "Dot", etc.
'`': 'backtick',
'~': 'tilde',
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/NavList/NavList.figma.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ figma.connect(
example: ({actionList}) => <NavList.Item href="#">{actionList.text}</NavList.Item>,
},
)
/** Collapsable item **/
/** Collapsible item **/
figma.connect(
NavList.Item,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=16716-62586&m=dev',
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ThemeProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const getServerHandoff = (id: string) => {
const serverData = document.getElementById(`__PRIMER_DATA_${id}__`)?.textContent
if (serverData) return JSON.parse(serverData)
} catch (_error) {
// if document/element does not exist or JSON is invalid, supress error
// if document/element does not exist or JSON is invalid, suppress error
}
return {}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/VisuallyHidden/VisuallyHidden.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import classes from './VisuallyHidden.module.css'

/**
* Provides a component that implements the "visually hidden" technique. This is
* analagous to the common `sr-only` class. Children that are rendered inside
* analogous to the common `sr-only` class. Children that are rendered inside
* this component will not be visible but will be available to screen readers.
*
* Note: if this component, or a descendant, has focus then this component will
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/* make space for the underline */
min-height: var(--control-xlarge-size, 48px);

/* using a box-shadow instead of a border to accomodate 'overflow-y: hidden' on UnderlinePanels */
/* using a box-shadow instead of a border to accommodate 'overflow-y: hidden' on UnderlinePanels */
/* stylelint-disable-next-line primer/box-shadow */
box-shadow: inset 0 -1px var(--borderColor-muted);

Expand Down Expand Up @@ -136,7 +136,8 @@
.LoadingCounter {
display: inline-block;
width: 1.5rem;
height: 1rem; /* 16px */
height: 1rem;
/* 16px */
background-color: var(--bgColor-neutral-muted);
border-color: var(--borderColor-default);
/* stylelint-disable-next-line primer/borders */
Expand Down
Loading