-
Notifications
You must be signed in to change notification settings - Fork 646
SelectPanel: Remove feature flag from preventBubbling
#7192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5f5ccee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6902 |
|
🟢 ci completed with status |
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the usingRemoveActiveDescendant feature flag from the SelectPanel's preventBubbling function and adds support for the forward slash (/) key to prevent event bubbling during typeahead interactions.
Key Changes
- Removes the conditional application of
preventBubblingbased on theusingRemoveActiveDescendantfeature flag, making it always active - Adds the forward slash (
/) key to the set of keys that trigger bubble prevention (alongside alphabet keys) - Removes the feature flag variable declaration from the component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/SelectPanel/SelectPanel.tsx | Removes usingRemoveActiveDescendant feature flag declaration and conditional logic; unconditionally applies preventBubbling to overlay keyDown handler; adds forward slash key handling to preventBubbling function |
| .changeset/solid-turkeys-shop.md | Adds changeset documenting the removal of usingRemoveActiveDescendant usage as a patch release |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Part of https://github.com/github/primer/issues/5900
Removes FF
usingRemoveActiveDescendantfrom bubbling prevention function, also accounts for\.Changelog
New
\key to bubble prevention functionRemoved
usingRemoveActiveDescendantusageRollout strategy
Testing & Reviewing
Merge checklist