Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

Closes #5286

This PR deprecates the icon prop in the Banner component in favor of leadingVisual. It also fixes the SecondaryAction styling and improves the Storybook Playground selecting leadingVisual.

Changelog

  1. Deprecate icon prop and add leadingVisual instead
  2. BannerSecondaryAction uses variant="invisible" instead of variant="link"
  3. Fixed Storybook Playground control for leadingVisual

Rollout strategy

  • Patch release

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

🦋 Changeset detected

Latest commit: 3f802ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7197 November 13, 2025 23:20 Inactive
@liuliu-dev liuliu-dev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 13, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 13, 2025
@liuliu-dev liuliu-dev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 13, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7197 November 13, 2025 23:45 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6872

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Nov 13, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 14, 2025
@liuliu-dev liuliu-dev marked this pull request as ready for review November 17, 2025 21:10
@liuliu-dev liuliu-dev requested review from a team as code owners November 17, 2025 21:10
@liuliu-dev liuliu-dev requested review from Copilot, langermank and lukasoppermann and removed request for Copilot November 17, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants