-
Notifications
You must be signed in to change notification settings - Fork 646
Banner: Deprecate icon prop in favor of leadingVisual, fix SecondaryAction styling and playground story
#7197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3f802ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6872 |
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
🟢 ci completed with status |
Closes #5286
This PR deprecates the
iconprop in theBannercomponent in favor ofleadingVisual. It also fixes theSecondaryActionstyling and improves the Storybook Playground selectingleadingVisual.Changelog
iconprop and addleadingVisualinsteadBannerSecondaryActionusesvariant="invisible"instead ofvariant="link"leadingVisualRollout strategy
Testing & Reviewing
Merge checklist