⚡ Bolt: [performance improvement] Memoize WebSocket list items to prevent re-renders#122
⚡ Bolt: [performance improvement] Memoize WebSocket list items to prevent re-renders#122primoscope wants to merge 1 commit intomainfrom
Conversation
…vent re-renders Co-authored-by: dzp5103 <214723817+dzp5103@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Extracted the inline
LogItemandDownloadItemcomponents fromLogPanel.tsxandProgressPanel.tsxrespectively, and wrapped them inReact.memo(). Also hoisted pure helper functions likegetLogColor,formatSpeed,formatETA, andgetStatusColoroutside of the component bodies. Added inline comments to document the optimizations. Added a critical learning to.jules/bolt.md.🎯 Why: When building lists that receive high-frequency updates via WebSocket, rendering lists inline with helper functions defined inside the component body creates a massive re-render bottleneck. Because a single WebSocket update updates the entire array state, React was re-rendering all list items instead of just the changed ones, and re-allocating helper functions on every single render cycle.
📊 Impact: Prevents unnecessary re-renders of the entire download/log list when high-frequency WebSocket updates arrive. Only the specific items that change (or new items that are appended) will trigger a render. This greatly reduces CPU overhead and DOM updates on the frontend.
🔬 Measurement: To verify, you can use React Developer Tools Profiler. Start a mock server sending WebSocket events every second and observe the
ProgressPanelandLogPanelcomponents. You will see thatDownloadItemandLogItemcomponents do not re-render unless their specificdownloadorlogprops change.PR created automatically by Jules for task 12413171551721026586 started by @dzp5103