⚡ Bolt: [performance improvement] Memoize list items in ProgressPanel and LogPanel#126
⚡ Bolt: [performance improvement] Memoize list items in ProgressPanel and LogPanel#126primoscope wants to merge 2 commits intomainfrom
Conversation
Co-authored-by: dzp5103 <214723817+dzp5103@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: dzp5103 <214723817+dzp5103@users.noreply.github.com>
💡 What: Extracted
DownloadItemandLogIteminner.map()closures into their ownReact.memocomponents inProgressPanel.tsxandLogPanel.tsx. Also moved helper functions (formatSpeed,formatETA,getStatusColor,getLogColor) outside of the main component scope so they are not recreated on every render. Log messages now generate an explicitidwhen received, replacing array indices as the component key to ensure stability during filtering or truncation.🎯 Why: Component lists populated by fast-updating WebSocket streams (like progress updates or chatty logs) cause the entire parent component to re-render. Since the WebSocket sends new object references, React forces a full reconciliation of the entire list, even for elements that haven't changed.
📊 Impact: Expected to significantly reduce React reconcile cycles and DOM manipulation on the frontend, resulting in lower CPU usage and a smoother interface, particularly when there are dozens of active downloads or hundreds of logs. Only the specific download that receives a progress update will re-render.
🔬 Measurement: Verify by starting multiple downloads or producing many logs while observing the React Profiler. You will see that previously unchanged items would re-render continuously, and now they will skip re-rendering.
PR created automatically by Jules for task 1929547609096872959 started by @dzp5103