⚡ Bolt: Extract and memoize DownloadItem to prevent unnecessary re-renders#130
⚡ Bolt: Extract and memoize DownloadItem to prevent unnecessary re-renders#130primoscope wants to merge 1 commit intomainfrom
Conversation
…nders Extracted the download item rendering logic in `ProgressPanel.tsx` into its own `DownloadItem` component and wrapped it in `React.memo` using a custom deep equality function. This optimizes the component by preventing the entire list from re-rendering whenever the `downloads` array is updated via WebSocket pushes or the 5-second polling fallback. Co-authored-by: dzp5103 <214723817+dzp5103@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Extracted the inner JSX of the
downloads.mapinProgressPanel.tsxinto a standaloneDownloadItemcomponent, and wrapped it withReact.memousing a custom equality function that checks the relevant primitive fields (progress,status,download_speed,eta_seconds, etc.).🎯 Why: The
ProgressPanelreceives frequent updates via WebSockets and a 5-second polling fallback. Because thedownloadsarray is entirely replaced on each update, React forces a re-render of every single download item in the list, even if their specific status or progress hasn't changed. This causes unnecessary CPU usage and DOM diffing, especially when the active downloads list grows.📊 Impact: Reduces unnecessary re-renders of download items by ~100% for unchanged items. Only items that actually receive progress or status updates will now trigger a re-render.
🔬 Measurement: Verify by starting multiple downloads and observing React DevTools Profiler while progress updates stream in; only the specifically updating rows will flash/re-render. Tests pass and UI is visually unchanged.
PR created automatically by Jules for task 13521345905509442809 started by @dzp5103