Skip to content

Add instance configuration method for directing configuring an instance#139

Merged
bkegley merged 3 commits intomainfrom
bk/add-instance-configuration-method
Mar 31, 2026
Merged

Add instance configuration method for directing configuring an instance#139
bkegley merged 3 commits intomainfrom
bk/add-instance-configuration-method

Conversation

@bkegley
Copy link
Copy Markdown
Contributor

@bkegley bkegley commented Mar 31, 2026

This adds a new editInstanceConfiguration method that allows directly configuring an existing instance in the config wizard.

Example usage:

    prismatic.editInstanceConfiguration({
      instanceId,
      selector: `#${embeddedDivId}`,
      theme: "LIGHT",
      screenConfiguration: {
        configurationWizard: {
          triggerDetailsConfiguration: "hidden",
        },
      },
      onCancel: onClose,
      onSuccess: onClose,
      onDelete: onClose,
    });

return;
}

window.addEventListener("message", (event: MessageEvent<{ event: string }>) => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will leak the event listener. You will need to provide an abort controller like what we did in iframe.ts

@bkegley bkegley changed the title Bk/add instance configuration method Add instance configuration method for directing configuring an instance Mar 31, 2026
@bkegley bkegley merged commit 33af252 into main Mar 31, 2026
1 check passed
@bkegley bkegley deleted the bk/add-instance-configuration-method branch March 31, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants