Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
lucasloisp
reviewed
Mar 23, 2026
lucasloisp
reviewed
Mar 23, 2026
Added clarity for internal package
lucasloisp
reviewed
Mar 25, 2026
lucasloisp
reviewed
Mar 25, 2026
Collaborator
There was a problem hiding this comment.
Do we actually need this file? Given we're referencing the asmdef directly and not via upm
Collaborator
Author
There was a problem hiding this comment.
Technically, no. It was nice to have if we wanted to use it with UPM.
lucasloisp
reviewed
Mar 25, 2026
SDK/ExternalDependencies/jsoncanonicalizer/Runtime/Org.Webpki.JsonCanonicalizer.asmdef
Outdated
Show resolved
Hide resolved
Fix nit Co-authored-by: Lucas Lois <lucas.lois@privy.io>
…JsonCanonicalizer.asmdef Fixed autoreferencing assembly. Co-authored-by: Lucas Lois <lucas.lois@privy.io>
lucasloisp
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the management of external dependencies in the SDK by removing the previously bundled
NewtonsoftJsonand migrating it to a package dependency, while embedding a new Unity Package Manager (UPM) version of the JSON canonicalizer (jsoncanonicalizer-upm). It cleans up legacy plugin files and metadata, introduces new documentation and licensing for the canonicalizer, and adds the canonicalizer's source code directly to the project.Dependency management changes:
NewtonsoftJsonplugin DLLs and their associated.metaand configuration files fromSDK/ExternalDependencies, asNewtonsoftJsonis now referenced viaSDK/package.jsonas a package dependency. ([[1]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-20719114e8d7172d97e51794666db737186584198ec895be11f5ec0c58e810bbL1-L9),[[2]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-415c66785a7febea5c608c27ac4e403060206d4f085947a5622fc607df3e37e0L1-L129),[[3]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-41bb741da9c257dc2046bf8ec155cdae0719f838788aebe5746ff0eba225ca34L1-L82),F214c1d1L1,[[4]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-6fa042666692424f992de49c8b67a83b8ec376c36fe8788dee7429bd02090dd5L2-R2))SDK/ExternalDependencies/README.mdto reflect the new dependency management approach:NewtonsoftJsonis now a package dependency, andjsoncanonicalizer-upmis embedded and referenced as an assembly. ([SDK/ExternalDependencies/README.mdL6-R8](https://github.com/privy-io/unity-sdk/pull/25/files#diff-44cdbb0f55a4d8f8944ea96404fd0e0fa2dffd2a1f02fb6f728f36ccedff9424L6-R8))JSON canonicalizer embedding:
jsoncanonicalizer-upmUnity package, including its source code (such asJsonCanonicalizer.cs,NumberCachedPowers.cs, and related.metafiles) and a newREADME.mddescribing usage, installation, and licensing. ([[1]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-4bc41911aa26d3976fffff8b81868569d40b8d2b5307d156c2cd8b303c84b11dR1-R62),[[2]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-a833a28d07c24247e3660323a1ab1f0445f1adb8d196a830fbd06179dfd841bbR1-R11),[[3]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-8e572a79323f0f71f77644a4524cbb4676a2fde4ea98b7c5ba4d9d42264822c0R1-R170),[[4]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-a5a7b639671bc98eb95885d588e9d2e22450a4bba2067165322ad92bcc937cbbR1-R11),[[5]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-29d50e0e71af13411b1bdd7f13d02066db2199254fb94e9cb800ef57258bbfc6R1-R11)).metafiles. ([[1]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-08a3d613292835d97d42b2c9b65fe0f67964747e186a3e9381b1fac6e09316b2R1-R13),[[2]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-d4f8a622b7d0215ff36d448bcb3f45f4cc8213e4ce885fb949b216f1e7101432L2-R2))Cleanup of legacy files:
jsoncanonicalizerplugin DLLs and associated.metafiles, as the new UPM package now provides the canonicalizer functionality. ([[1]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-83bf21b0721361b6501834ab0d2f604d2eb924c2c06c0bcde954e3cbc487bb7bL1-L8),[[2]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-519e0fb88549ba54cdc17f5ae60ce6d577d0cc5ab951205efb8424c85ef9dab8L1-L33),[[3]](https://github.com/privy-io/unity-sdk/pull/25/files#diff-d5f560a5503bce5e4e69d59952eec27f79e94c3391afbbc6a98224e3f7d3b4a1L1-L33))jsoncanonicalizer.metafile with a new GUID to reflect the new package structure. ([SDK/ExternalDependencies/jsoncanonicalizer.metaL2-R2](https://github.com/privy-io/unity-sdk/pull/25/files#diff-f5b10c58af40018280345d75f69ecfd3968b3eae754e531c05b7f13cd69923d3L2-R2))These changes modernize dependency management, reduce repository bloat, and improve maintainability by leveraging Unity's package system.