Skip to content

temp esc editor key, update open/close file menu aria label #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions client/modules/IDE/components/Editor/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ class Editor extends React.Component {
},
Enter: 'emmetInsertLineBreak',
Esc: 'emmetResetAbbreviation',
[`Shift-${metaKey}-E`]: (cm) => {
cm.getInputField().blur();
},
[`Shift-Tab`]: false,
[`${metaKey}-Enter`]: () => null,
[`Shift-${metaKey}-Enter`]: () => null,
Expand Down Expand Up @@ -552,7 +555,7 @@ class Editor extends React.Component {
<section className={editorSectionClass}>
<div className="editor__header">
<button
aria-label={this.props.t('Editor.OpenSketchARIA')}
aria-label={this.props.t('Editor.CloseSketchARIA')}
className="sidebar__contract"
onClick={() => {
this.props.collapseSidebar();
Expand All @@ -562,7 +565,7 @@ class Editor extends React.Component {
<LeftArrowIcon focusable="false" aria-hidden="true" />
</button>
<button
aria-label={this.props.t('Editor.CloseSketchARIA')}
aria-label={this.props.t('Editor.OpenSketchARIA')}
className="sidebar__expand"
onClick={this.props.expandSidebar}
>
Expand Down