Skip to content

Fix banner embed #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

Fix banner embed #3638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd4d0b
banner not visible in fullscreen
raclim Sep 10, 2025
325350d
banner not visible in embed
raclim Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions client/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,25 @@ const initialState = window.__INITIAL_STATE__;

const store = configureStore(initialState);

// Add a banner to the page
const banner = document.createElement('div');
banner.id = 'processing-banner';
document.body.appendChild(banner);
if (
window.location.href.indexOf('full') === -1 &&
window.location.href.indexOf('embed') === -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue with this is it will also hide the banner if the username includes full or embed

) {
// Add a banner to the page
const banner = document.createElement('div');
banner.id = 'processing-banner';
document.body.appendChild(banner);

const link = document.createElement('link');
link.rel = 'stylesheet';
link.href = 'https://foundation-donate-banner.netlify.app/static/css/main.css';
document.head.appendChild(link);
const link = document.createElement('link');
link.rel = 'stylesheet';
link.href =
'https://foundation-donate-banner.netlify.app/static/css/main.css';
document.head.appendChild(link);

const script = document.createElement('script');
script.src = 'https://foundation-donate-banner.netlify.app/static/js/main.js';
document.body.appendChild(script);
const script = document.createElement('script');
script.src = 'https://foundation-donate-banner.netlify.app/static/js/main.js';
document.body.appendChild(script);

if (window.location.href.indexOf('full') === -1) {
const buttonScript = document.createElement('script');
buttonScript.type = 'text/javascript';
buttonScript.defer = true;
Expand Down
Loading