-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
pr05 Typescript Migration #13: Migrate the User Model (& API Key schema) #3672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clairep94
wants to merge
23
commits into
processing:develop
Choose a base branch
from
clairep94:pr05/migrate_user_model_finalattempt
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pr05 Typescript Migration #13: Migrate the User Model (& API Key schema) #3672
clairep94
wants to merge
23
commits into
processing:develop
from
clairep94:pr05/migrate_user_model_finalattempt
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanniie
approved these changes
Sep 27, 2025
lastLoginTimestamp: { type: Date } | ||
}, | ||
{ timestamps: true, usePushEach: true } | ||
{ timestamps: true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need usePushEach anymore? is it set to that by default? just wanted to make sure it didn't slip through the cracks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of the user model to ts
Changes:
inferSchemaType
and other infers but this was honestly really hard to debug and it was easier to explicity define what we expect from the types and feed it to the mongoose scheme definition, and attach the extra Document methodsI have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123