solves docs issue 837 for p5.js 2.x #877
Conversation
…-main2 Update contributors list
This reverts commit 568a8b8.
Fully unmount sketches that go out of frame
Add libraries, fix bug with old featured ones not getting cycled
FPS library
Signed-off-by: shiva <shiva_05@outlook.com>
Updated description and `sourceURL`.
…th no args and memoize getCurationSketches
…come from getSketch
Add an Issue template for reporting accessibility issues
Update placeholders in 4.accessibility.yml
Fixes an accidental inclusion of an unnecessary field
Update 4.accessibility.yml to remove extra "steps to reproduce field"
There was a problem hiding this comment.
Hi @NalinDalal Thanks so much for your wokr. I think, you have opend up a PR targeting the main branch. The changes are supposed to have in 2.0 branch of p5.js-website. Would you mind re targeting your PR according to that?
|
For now, I have changed the base of your PR by clicking on edit button in the top right and then changing the target branch, but for the code, you probably have to Feel free to ask for help if you face any issues. Also, it's totally fine if you close this PR and open up a new one targeting the |
|
so is it done @perminder-17 ? |
Fully unmount sketches that go out of frame
Fixes an accidental inclusion of an unnecessary field
|
Superseded by #879 — clean rebase onto 2.0 as requested. |
Actual Behavior
The “Getting Started with Node.js” tutorial is still using p5.js 1.x patterns (e.g. preload(), old APIs, external sketches locked to 1.x). Legacy p5.js 1.x APIs (e.g. old shape-drawing signatures) remain in the code samples. Several external Web Editor sketches are locked to p5.js 1.x and won’t run under 2.x.
Expected Behavior
Since p5.js 2.0 has removed preload() and other legacy methods in favor of async/await and updated several APIs, we need to refresh this tutorial so it only uses supported 2.x functionality. Every linked sketch should has been forked (or updated) to use p5.js 2.x so examples execute correctly.
Hence I updated the docs for the required 2.x version
I have tested, linted and ran the code locally to ensure no breakage occurs