-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Refactor typescript type generation #8114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.0
Are you sure you want to change the base?
Conversation
I think feature-wise, this is good to go now. @limzykenneth @ksen0 let me know if the updates to type exporting, to the test CI action, and to the dependencies (adding typescript as a dev dependency for testing) make sense! |
ok at least for my company's usage, this gets me to 0 type errors compared to before. there may still be room for improvement because the 1.x types were lacking sometimes too, but I feel like this is at least enough for us! |
Noticed one more thing I was missing: types for p5.strands GLSL methods. So far the types for those are pretty unspecific, e.g. One other typing speedbump: p5.strands/GLSL have a |
Resolves #7862
Resolves #7938
This builds off of #7863 and refactors how typescript type generation is done, and adds integration tests to make sure sketches that use the types all work correctly. We can add new .ts files into the
test/types
folder to verify that they work correctly.TODO:
Better types for callback function parametersUpdate: probably going to leave this for now since it'll affect the reference generation too. Future PR maybe!PR Checklist
npm run lint
passes