Add tests for documentation and release build for cargo targets#1665
Merged
flowzone-app[bot] merged 1 commit intomasterfrom Mar 5, 2026
Merged
Add tests for documentation and release build for cargo targets#1665flowzone-app[bot] merged 1 commit intomasterfrom
flowzone-app[bot] merged 1 commit intomasterfrom
Conversation
pipex
force-pushed
the
cargo-build-test
branch
from
cd91e42 to
4a7a996
Compare
Contributor
|
Website deployed to CF Pages, 👀 preview link https://9b1f4ee5.flowzone.pages.dev |
pipex
force-pushed
the
cargo-build-test
branch
from
4a7a996 to
6221402
Compare
pipex
changed the title
pipex
force-pushed
the
cargo-build-test
branch
from
6221402 to
0adcd8d
Compare
Contributor
|
/rebase |
|
Failed to rebase: Conflict detected when applying commit ec02442. Please resolve the conflict and push again. |
floion
force-pushed
the
cargo-build-test
branch
from
ec02442 to
afe7351
Compare
pipex
force-pushed
the
cargo-build-test
branch
2 times, most recently
from
e138450 to
dd17a63
Compare
Contributor
|
/rebase |
|
Failed to rebase: Conflict detected when applying commit dd17a63. Please resolve the conflict and push again. |
There was a problem hiding this comment.
Pull request overview
Updates the Rust cargo_test job in Flowzone CI to ensure doctests are exercised (by removing --all-targets) while still covering examples/benches and validating --release builds when the publish job won’t run.
Changes:
- Remove
--all-targetsfromcross testto allow doctests to run. - Add an explicit
cross test --examples --benchesstep. - Add a conditional
cross build --releasestep wheninputs.rust_binariesis nottrue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
flowzone.yml |
Adjusts Rust test/build steps in the Flowzone pipeline template. |
.github/workflows/flowzone.yml |
Mirrors the same Rust test/build step changes in the GitHub Actions workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Modifies the test command removing `--all-targets` that skips docs tests and adds two more steps to the `cargo_test` job. - Test examples and benches if any to make up for the removal of `--all-targets`. - Checks that `cargo build --release` works if `cargo_publish` is false. The `cargo_publish` job already builds the binary so no need to test this twice. Change-type: patch
klutchell
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the cargo test command removing
--all-targetsthat skips docs testsand adds two more steps to the
cargo_testjob.--all-targets.cargo build --releaseworks ifcargo_publishis false.The
cargo_publishjob already builds the binary so no need to testthis twice.
Change-type: patch