Draft
Conversation
This allows transformer-bundles to only need transformers-core as their core dependency. The injected code for transforming the bundle into a transfomrer requires js-yaml as a dependency. Change-type: patch Signed-off-by: Carlo Miguel F. Cruz <carloc@balena.io>
cmfcruz
force-pushed
the
export-js-yaml
branch
from
0f137d9 to
a0e0f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives transformers tools to read/write yaml files without including additional yaml packages. The
index.tsfile injected by the transformer-bundle transformer needsjs-yamlas part of the dependencies. By exportingyamlas part of transformers-core, engineers would only need to includetransformers-coreas the bundle's dependency.Change-type: patch
Signed-off-by: Carlo Miguel F. Cruz carloc@balena.io