Conversation
|
💩 Code linting failed, use |
Georgon
requested review from
Umiacha and
petrCher
and removed request for
Umiacha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed version:
Исправлены тесты для rental-session. В данной версии все тесты рабочие.
В rental_session.py:
Помимо игр со скоупами есть два важных изменения, напрямую влияющие на работоспособность тестов.
В conftest.py:
Добавил новые фикстуры, необходимые для новых тестов, дабы в test_rental_session.py не было прямого обращения к БД. Также переписаны некоторые уже существующие фикстуры. Их изменения не влияют на другие файлы.
В test_rental_session.py:
Переписал уже существующие тесты, проверив их логику и работоспособность. Дописал новые. Также для ручки patch("/{session_id}") update_rental_session написал два теста на проверку прав для обычного пользователя и админа.