Add configurable timeout for stop_trace #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your contribution! I wonder if it would make sense to move the rest of the options ( |
Author
|
If there are other options already (that have a reasonable default) it
would make sense to merge options together I think. I didn't notice that
the other things you mention were options. I would reserve args for
required values -- especially since Erlang doesn't have things like default
values, etc... all of the function head variations look to get out of hand
pretty quickly...
…--Ian
On Wed, Oct 25, 2017 at 6:03 AM, Vlad Ki ***@***.***> wrote:
Thanks for your contribution! I wonder if it would make sense to move the
rest of the options (Mode and OutputFile) into your Options map as well.
Or, for consistency, just add Timeout as an extra argument and export it
as apply/5.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAveUDiX9a6RiwuYQ3UrCymCFvNVmxeks5svzG0gaJpZM4QCIaa>
.
|
|
Is this PR alive? If original author is not interested in finishing this, I could contribute. |
Author
|
I would welcome that. I used this for a quick project and opened the PR in
case it was useful to someone. I won’t be able to add to it anytime soon.
—Ian
…On Thu, Feb 4, 2021 at 3:11 AM Jakub Hajto ***@***.***> wrote:
Is this PR alive? If original author is not interested in finishing this,
I could contribute.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAC66IYRM4CGDSFKBEXBD3S5J6E5ANCNFSM4EAIQ2NA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working for me. I'm less familiar with erlang, so it might not be idiomatic. I looked into using proplists for the Options argument, but it doesn't seem to have a convenient guard that would work. Using a map, the calling syntax from Elixir is not idiomatic, but I'm not sure that matters.
Feedback welcome.
Fixes #13