Implement getObjectsSorted #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting by "count" or "term" ascending or descending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo zusammen,
die Sortierung der Begriffe im Filter der Suche hat für CustomDataType Plugins die CustomDataTypeCommonFacet benutzen nicht funktioniert.
Die Funktion getObjectsSorted war nicht implementiert (Definition hier: https://github.com/programmfabrik/easydb-library/blob/master/src/commons.coffee#L700). Getestet haben wir das mit unserem CustomDataTypeGND in einer easyDB Instanz mit Version 5.151.
Fehlerhafte Sortierung hier im Bild mit dem Fix, das CustomDataTypeGND Feld "Aufbewahrungsort (GND)" sollte alphabetisch sortiert sein wie die anderen Felder:
Ich hab sie jetzt implementiert, so dass nach Anzahl
countoder nach Begrifftermsortiert werden kann, so wie es in der Oberfläche im Filter eingestellt wurde.Könntet ihr das prüfen und die Anfrage akzeptieren, wenn es so passt?
Viele Grüße von der UB Heidelberg,
Nils Weiher