Skip to content

Update SessionHandler.php #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisWeller wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update SessionHandler.php #1

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42909c2
Update SessionHandler.php
Mar 19, 2019
7829e0b
Merge branch 'programster:master' into master
ChrisWeller Mar 3, 2022
f9c0ce4
Update to support PHP 8 with type definitions
ChrisWeller Aug 11, 2023
d54c17a
Garbage collection updated to use modified_timestamp field instead of…
ChrisWeller Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}
],
"require": {
"php": ">=7.0.0"
"php": ">=8.0.0"
},
"autoload": {
"psr-4": {
Expand Down
133 changes: 67 additions & 66 deletions src/SessionHandler.php
View file
Open in desktop
Copy link
Owner

@programster programster Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you fix this so that we have the original indentation using 4 spaces. This way the actual/real changes are easy to see/view.

Original file line number Diff line number Diff line change
Expand Up @@ -5,91 +5,92 @@

final class SessionHandler implements \SessionHandlerInterface
{
private $dbConnection; # the mysqli connection
private $dbTable; # name of the db table to store sessions in
private $m_maxAge;


/**
* Create the session handler.
* @param \mysqli $mysqli - the database connection to store sessions in.
* @param string $tableName - the table within the database to store session data in.
* @param int $maxAge - the maximum age in seconds of a session variable.
*/
public function __construct(\mysqli $mysqli, string $tableName, int $maxAge=86400)
{
$this->dbConnection = $mysqli;
$this->dbTable = $tableName;
$this->m_maxAge = $maxAge;

$createSessionsTableQuery =
"CREATE TABLE IF NOT EXISTS `{$this->dbTable}` (
private $dbConnection; # the mysqli connection
private $dbTable; # name of the db table to store sessions in
private $m_maxAge;


/**
* Create the session handler.
* @param \mysqli $mysqli - the database connection to store sessions in.
* @param string $tableName - the table within the database to store session data in.
* @param int $maxAge - the maximum age in seconds of a session variable.
*/
public function __construct(\mysqli $mysqli, string $tableName, int $maxAge=86400)
{
$this->dbConnection = $mysqli;
$this->dbTable = $tableName;
$this->m_maxAge = $maxAge;

$createSessionsTableQuery =
"CREATE TABLE IF NOT EXISTS `{$this->dbTable}` (
`id` varchar(32) NOT NULL,
`modified_timestamp` timestamp DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`data` mediumtext,
PRIMARY KEY (`id`),
KEY `modified_timestamp` (`modified_timestamp`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;";

$this->dbConnection->query($createSessionsTableQuery);
}
$this->dbConnection->query($createSessionsTableQuery);
}


public function open($savePath, $sessionName)
{
$sql = "DELETE FROM `{$this->dbTable}` WHERE `modified_timestamp` < (NOW() - INTERVAL {$this->m_maxAge} SECOND)";
return $this->dbConnection->query($sql);
}
public function open(string $savePath, string $sessionName) : bool
{
$sql = "DELETE FROM `{$this->dbTable}` WHERE `modified_timestamp` < (NOW() - INTERVAL {$this->m_maxAge} SECOND)";
return $this->dbConnection->query($sql);
}


public function close()
{
return $this->dbConnection->close();
}
public function close():bool
{
return $this->dbConnection->close();
}


public function read($id)
{
$sql = "SELECT `data` FROM `{$this->dbTable}` WHERE `id` = '{$id}'";
$result = $this->dbConnection->query($sql);
public function read($id):string|false
{
$sql = "SELECT `data` FROM `{$this->dbTable}` WHERE `id` = '{$id}'";
$result = $this->dbConnection->query($sql);

if ($result === false)
{
throw new \Exception("There is an issue with your session handler using MySQL.");
}
if ($result === false)
{
throw new \Exception("There is an issue with your session handler using MySQL.");
}

if ($result->num_rows === 0)
{
$result = "";
}
else
{
$row = $result->fetch_assoc();
$result = $row['data'];
}
if ($result->num_rows === 0)
{
$result = "";
}
else
{
$row = $result->fetch_assoc();
$result = $row['data'];
$result = $result === null ? "" : $result;
}

return $result;
}
return $result;
}


public function write($id, $data)
{
$sql = "REPLACE INTO `{$this->dbTable}` (id, data) VALUES('{$id}', '{$data}')";
return $this->dbConnection->query($sql);
}
public function write(string $id, string $data):bool
{
$sql = "REPLACE INTO `{$this->dbTable}` (id, data) VALUES('{$id}', '{$data}')";
return $this->dbConnection->query($sql);
}


public function destroy($id)
{
$sql = "DELETE FROM `{$this->dbTable}` WHERE `id` = '{$id}'";
return $this->dbConnection->query($sql);
}
public function destroy(string $id):bool
{
$sql = "DELETE FROM `{$this->dbTable}` WHERE `id` = '{$id}'";
return $this->dbConnection->query($sql);
}


public function gc($maxlifetime)
{
$minTime = time() - intval($maxlifetime);
$sql = "DELETE FROM `{$this->dbTable}` WHERE `timestamp` < '{$minTime}'";
return $this->dbConnection->query($sql);
}
}
public function gc(int $maxlifetime):int|false
{
$minTime = time() - intval($maxlifetime);
$sql = "DELETE FROM `{$this->dbTable}` WHERE `timestamp` < '{$minTime}'";
return $this->dbConnection->query($sql);
}
}