Open
Conversation
Author
|
ping :) |
|
Thanks for the PR, and apologies for the wait.. Is there a way to do the version check in a more automated fashion? i.e.:
It would allow nginx to be updated automatically and not get stuck behind me/someone updating this buildpack or someone waiting for the a newer buildstep to be published |
Author
|
yeah. I can look into that. I figured nginx isn't updated all that often, so it would be ok and worst case they could delete the cache directory on the box if they wanted latest. |
|
Hm, on second thought I'm OK with that. Could you change lines 5-7 to be independent of versions? Something like |
Author
|
great idea. I'll make that change later today |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will speed up deployment a bit