Skip to content

removal of hashtables and everything based on hashbase from tools.h #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Duskhorn wants to merge 59 commits into
base: main
Choose a base branch
from
Open

removal of hashtables and everything based on hashbase from tools.h #262

Duskhorn wants to merge 59 commits into from

Conversation

@Duskhorn
Copy link
Contributor

@Duskhorn Duskhorn commented Mar 1, 2023

Attempt to close Issue #257
Remade from #258

Duskhorn and others added 30 commits September 7, 2022 10:03
@Duskhorn
added VSCode specific folders to .gitignore for my mental sanity
d34c02d
@Duskhorn
added VSCode specific folders to .gitignore for my mental sanity part 2
9722139
@Duskhorn
std::map (issue project-imprimis#257) and ENUMERATE removal part 1
e3f8a1e
@Duskhorn
ENUMERATE removal part 2
d6b38a7
@Duskhorn
rebased => idents std::map in command.cpp (issue project-imprimis#257)
cbcca7c
@Duskhorn
rebase part 2
eb9ffc8
@Duskhorn
changed window, may have broken something. I'm not familiar of what h…
f64ca0d 
…appens by comparing *&& and *
@Duskhorn
more work towards Issue project-imprimis#257
3cf04e0
@Duskhorn
ui.cpp for project-imprimis#257
9a2c059
@Duskhorn
animmodel.h and .cpp for project-imprimis#257
e861ba9
@Duskhorn
I may have broken this, because I don't understand hashset. Wish me l…
2b2c916 
…uck, agent project-imprimis#257
@Duskhorn
rendermodel for issue project-imprimis#257
f171d64
@Duskhorn
rendertext for project-imprimis#257
21deeee
@Duskhorn
shader for project-imprimis#257
dc39026
@Duskhorn
last commit, brain mushy
82b966b
@Duskhorn
.gitignore
a136eaa
@Duskhorn
typo
3208416
@Duskhorn
man I'm so bad at this
7b6b3ba
@Duskhorn
fixed the cs.h
b371b89
@Duskhorn
fixed last things..?
3672056
@Duskhorn
this errors so badly, and I don't know what to do
f288e1a
@Duskhorn
overloaded std::hash<animmodel::shaderparam>
101ed8f
@Duskhorn
Merge branch 'project-imprimis:main' into map
1a79799
@Duskhorn
typo in docstring
0ecf3e6
@Duskhorn
added operator== overload for animmodel::shaderparams
40fd71a
@Duskhorn
moved operator overload definition in .cpp file
3ded74c
@Duskhorn
blank slate, reverted changes
cd85b33
@Duskhorn
Merge branch 'project-imprimis:main' into map
1ee9423
@Duskhorn
merged main into current branch
c1664ff
@Duskhorn
fixed for loop indentations to fit formatting style
614929f
no-lex
no-lex requested changes Mar 2, 2023
View reviewed changes
@Duskhorn
Copy link
Contributor Author

Duskhorn commented Mar 3, 2023 •
edited
Loading

Right now I just have 3 hashtables left.

  1. hashtable<vec, int> share; in animmodel.h:144
  2. hashtable<ivec, int> verthash(1<<11); in obj.cpp:75
  3. static hashtable<cfkey, cfpolys> cpolys; in octacube.cpp:718

For the first two, we either go the std::hash route or we reimplement them.
For the thrid one, I'm not sure

@Duskhorn Duskhorn closed this Mar 3, 2023
@Duskhorn Duskhorn reopened this Mar 3, 2023
@Duskhorn Duskhorn mentioned this pull request Mar 4, 2023
Merged
@Duskhorn
Copy link
Contributor Author

Duskhorn commented Nov 11, 2023

sooo what do we do about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@no-lex no-lex no-lex requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Duskhorn @no-lex