Skip to content

Enhance Containerfile to include koku-ui-sources package and build process#5124

Merged
rawagner merged 1 commit intoproject-koku:mainfrom
jkilzi:sources-ui
Apr 29, 2026
Merged

Enhance Containerfile to include koku-ui-sources package and build process#5124
rawagner merged 1 commit intoproject-koku:mainfrom
jkilzi:sources-ui

Conversation

@jkilzi
Copy link
Copy Markdown
Contributor

@jkilzi jkilzi commented Apr 29, 2026

Signed-off-by: Jonathan Kilzi jkilzi@redhat.com

…ocess

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
@jkilzi jkilzi requested a review from a team as a code owner April 29, 2026 09:42
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the koku-ui-sources sub-application into the koku-ui-onprem build process by adding the necessary copy and build steps to the Containerfile. Review feedback suggests optimizing the Docker build order to enhance layer caching efficiency and renaming the output directory for the sources application to costManagementSources to ensure consistency with existing sub-applications.

RUN npm run build:onprem --workspace=@koku-ui/koku-ui-ros

COPY apps/koku-ui-sources ./apps/koku-ui-sources/
RUN npm run build:onprem --workspace=@koku-ui/koku-ui-sources
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The build order in this Containerfile is suboptimal for Docker layer caching and appears inconsistent with the build:onprem script in the root package.json. Currently, the main onprem application is built first (lines 17-18), which means any change to the onprem source code will invalidate the cache for all subsequent sub-app builds (hccm, ros, and sources). Following the order defined in package.json (ros -> hccm -> sources -> onprem) by moving the onprem build to the end of the builder stage would significantly improve build efficiency for the most frequent code changes.

COPY --from=builder /app/apps/koku-ui-onprem/dist ./onprem
COPY --from=builder /app/apps/koku-ui-hccm/dist ./costManagement
COPY --from=builder /app/apps/koku-ui-ros/dist ./costManagementRos
COPY --from=builder /app/apps/koku-ui-sources/dist ./sources
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the other sub-applications in the final image (costManagement and costManagementRos), consider naming the destination directory costManagementSources instead of sources. This aligns with the naming convention used for other Cost Management components.

COPY --from=builder /app/apps/koku-ui-sources/dist ./costManagementSources

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.08%. Comparing base (22b1923) to head (bcc637d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5124   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files         578      578           
  Lines       12401    12401           
  Branches     2969     2965    -4     
=======================================
  Hits         9931     9931           
  Misses       2298     2298           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masayag
Copy link
Copy Markdown

masayag commented Apr 29, 2026

@dlabrecq @rawagner pls review

@rawagner rawagner merged commit 9664645 into project-koku:main Apr 29, 2026
9 checks passed
@jkilzi jkilzi deleted the sources-ui branch May 3, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants