-
Notifications
You must be signed in to change notification settings - Fork 19
Fix: Allow partial data generation on the last day of the month #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
esebesto
wants to merge
11
commits into
main
Choose a base branch
from
esebesto/ocp_last_of_the_month
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
16fc083
Attempt to fix OCP last of the month issue
esebesto 5285c95
update
esebesto 1e2456b
Update comment
esebesto e035b6d
uptick nise
esebesto f44457a
Updae
esebesto 8399fcc
omit timezone
esebesto 1247d4b
improve readability
esebesto f40244a
be extra careful
esebesto 1501798
let's make gemini finally happy?
esebesto e65137b
fix version
esebesto c9c16a0
fix lint
esebesto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| from .helpers import gcp_calculate_persistent_disk_usage_amount | ||
| from .helpers import gcp_calculate_usage_amount_in_pricing | ||
|
|
||
| __version__ = "5.4.1" | ||
| VERSION = __version__.split(".") | ||
| __version__ = "5.4.2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition relies on
options.get("end_date")being adatetime.datetime, but in some scenarios (last day of the month) with no--end-dateit will be None, so the if is never entered.Does that make sense?