feat: drop RPi.gpio dependency (switch to libgpiod), add i2c bus selection#71
Open
UncleRus wants to merge 2 commits intoproject-owner:masterfrom
Open
feat: drop RPi.gpio dependency (switch to libgpiod), add i2c bus selection#71UncleRus wants to merge 2 commits intoproject-owner:masterfrom
UncleRus wants to merge 2 commits intoproject-owner:masterfrom
Conversation
UncleRus
changed the title
Owner
|
Hi, thank you for providing the PR! |
Author
|
Hi! The Orange Pi doesn't and can't have the RPi.gpio library. However, all modern Linux versions support |
Owner
|
OK, please squash commits into one. The whole player code was written without using input/output data types. Is it possible to do the same for your changes? Also the naming convention for the code in player doesn't use underscore as a variable/function name prefix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving from RPi.GPIO to libgpiod (using Python
gpiodbindings) enables support for GPIO buttons and incremental encoders across any modern Linux system, not just Raspberry Pi. To further enhance this compatibility, the I2C_PORT parameter has been introduced, allowing the use of any available I2C bus for GPIO, rather than being restricted to bus 1.This PR was created during the work to get Peppy running on OrangePi 3B.