Clearer UI behavior for adding or knocking on rooms/spaces #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure the Home screen is actually visible when navigating to an existing or newly-joined room (in `navigate_to_room()`). * Move the selected tab / screen to the top-level `AppState`, which allows the `App` widget (and others) to access it.
kevinaboos
force-pushed
the
knocked_rooms
branch
from
ebced28 to
abd3552
Compare
Fixes issue where cargo makepad itself fails CI because it builds with warnings
This avoids CI actions failing due to build failures in the makepad upstream `dev` branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.