general modbus entity/service #227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcpettus
reviewed
Sep 23, 2025
Dockerfile
Outdated
|
|
||
| FROM ${img_user}/${img_repo}:${img_tag} | ||
|
|
||
| RUN pip install pymodbus slack_sdk |
There was a problem hiding this comment.
should remove slack_sdk from this PR (that's from your working code on slack integration)
| @@ -0,0 +1,3 @@ | |||
| __all__ = [] | |||
There was a problem hiding this comment.
@nsoblath : should we have these extensions flat in the dripline/extensions/ directory? or in their own subdirectory like jitter was (doesn't seem to add value)
Contributor
|
We should cross-compare and harmonize with #223 |
…y this the byteorder argument gets oppsolate and the wordorder argument has to be part of the entity not the service. Service now returns the register bytes and entity has to decode them.
… and single value.
… apply type conversion to set method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.