Skip to content

Conversation

@psurukuc
Copy link

Bindings for normal and reference MEMVARs. Currently doesn't yet include PTR, SHARED_PTR, and ATOMIC versions.

@psurukuc psurukuc requested review from MCFlowMace and nsoblath June 21, 2022 21:35
Copy link
Member

@nsoblath nsoblath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great. I think it needs three things to be complete:

  1. Completeness: Finish macros for the other types of MEMVARs. I know it's easy to stop with the ones that we're actively using, but since this is a finite and stable set of things to include, and has a pretty consistent pattern, I'd really like to see the remaining items included.
  2. Documentation: The header file needs some documentation on how to use it. Preferrably this would be in a doxygen-compatible way for the file. As an example, check out Utility/MemberVariable.hh.
  3. Unit testing: I suggest a simple test where you create a C++ class that uses a each of the MEMVAR macros (at least one of each type, i.e. normal, ref, ptr, shared_ptr, and atomic), bind them with the macro, and then in the test demonstrate that you can access the properties in python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants