Signal handling fix and logging modification

.github/workflows/run_tests.yaml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-24.04, ubuntu-22.04, macos-15, macos-14, macos-13]
+        os: [ubuntu-24.04, ubuntu-22.04, macos-15-intel, macos-15, macos-14]
 
     steps:
 

CMakeLists.txt

@@ -85,7 +85,7 @@ set( SPDLOG_BUILD_SHARED TRUE )
 set( SPDLOG_INSTALL TRUE )
 FetchContent_Declare( spdlog
     GIT_REPOSITORY https://github.com/project8/spdlog.git
-    GIT_TAG v1.x_p8
+    GIT_TAG v1.x_p8_r1
 )
 FetchContent_MakeAvailable( spdlog )
 # if Scarab is being built as a submodule, the parent might need to know where to find spdlog

VERSION

@@ -1 +1 @@
-3 13 4
+3 13 5

changelog.md

@@ -9,6 +9,22 @@ Types of changes: Added, Changed, Deprecated, Removed, Fixed, Security
 
 ## [Unreleased]
 
+## [3.13.5] - 2025-12-22
+
+### Changed
+
+- Signal handling now requires a dedicated thread
+- Updated GHA runners
+- Removed local loggers
+
+### Fixed
+
+- Tied spdlog to a tag and not a branch
+- Updated spdlog fork from upstream
+- signal_handler signal handling functions use only approved function calls
+- Check if spdlog thread pool exists before making a new one
+
+
 ## [3.13.4] - 2025-11-04
 
 ### Fixed

library/logger/logger.cc

@@ -37,7 +37,12 @@ namespace scarab
             spd_initializer( a_pattern ),
             f_sink()
     {
-        spdlog::init_thread_pool(8192, 1);
+        // We check before creating the new thread pool because we've had problems in some situations (e.g. when started from Python)
+        // with a new thread pool being created and the old one being killed, resulting in strange errors during execution
+        if( ! spdlog::thread_pool() )
+        {
+            spdlog::init_thread_pool(8192, 1);
+        }
         f_sink = std::make_shared< spdlog::sinks::stdout_color_sink_mt >();
         f_sink->set_pattern( f_pattern ); 
         auto at_exit_fcn = [](){ logger::stop_using_spd_async(); };
@@ -201,7 +206,7 @@ namespace scarab
     void logger::reset_using_spd_async()
     {
 #ifdef SCARAB_LOGGER_DEBUG
-        std::cerr << "Resetting use of spd async" << std::endl;
+        std::cerr << "[logger::reset_using_spd_async()] Resetting use of spd async" << std::endl;
 #endif
         logger::using_spd_async().store(true);
         std::set< logger* >& t_all_loggers = logger::all_loggers();

library/logger/logger.hh

@@ -188,7 +188,7 @@ namespace scarab
             f_initializer_ptr( nullptr )
     {
 #ifdef SCARAB_LOGGER_DEBUG
-        std::cout << "Logger <" << a_name << "> was initialized from <" << a_file << ":" << a_line << ">; type: " << ::scarab::type( *this ) << std::endl;
+        std::cerr << "[logger_type constructor] Logger <" << a_name << "> was initialized from <" << a_file << ":" << a_line << ">; type: " << ::scarab::type( *this ) << std::endl;
 #endif
         // Start the backend, but only once
         static initializer_x s_init;
@@ -223,13 +223,13 @@ namespace scarab
 
 /// Creates a local scarab::logger object with variable name a_logger
 /// Uses spdlog's asynchronous logger; spdlog logger name will be a_name.
-#define LOCAL_LOGGER( a_logger, a_name ) \
-    ::scarab::logger_type< ::scarab::spd_initializer_async_stdout_color_mt > a_logger( a_name, __FILE_NAME__, __LINE__ );
+//#define LOCAL_LOGGER( a_logger, a_name ) \
+//    ::scarab::logger_type< ::scarab::spd_initializer_async_stdout_color_mt > a_logger( a_name, __FILE_NAME__, __LINE__ );
 
 /// Creates a local single-threaded (non-asynchronous) scarab::logger object with variable name a_logger
 /// Uses spdlog's basic logger; spdlog logger name will be a_name.
-#define LOCAL_LOGGER_ST( a_logger, a_name ) \
-    ::scarab::logger_type< ::scarab::spd_initializer_stdout_color > a_logger( a_name, __FILE_NAME__, __LINE__ );
+//#define LOCAL_LOGGER_ST( a_logger, a_name ) \
+//    ::scarab::logger_type< ::scarab::spd_initializer_stdout_color > a_logger( a_name, __FILE_NAME__, __LINE__ );
 
 // Logging functions
 #ifdef NDEBUG

library/utility/indexed_factory.hh

@@ -212,7 +212,7 @@ namespace scarab
     void indexed_factory< XIndexType, XBaseType, XArgs... >::register_class( const XIndexType& a_index, const base_registrar< XBaseType, XArgs... >* a_registrar )
     {
         // A local (non-static) logger is created inside this function to avoid static initialization order problems
-        LOCAL_LOGGER( slog_ind_factory_reg, "indexed_factory_register");
+        LOGGER( slog_ind_factory_reg, "indexed_factory_register");
 
         std::unique_lock< std::mutex > t_lock( this->f_factory_mutex );
         FactoryCIt it = fMap->find(a_index);
@@ -235,7 +235,7 @@ namespace scarab
     void indexed_factory< XIndexType, XBaseType, XArgs... >::remove_class(const XIndexType& a_index )
     {
         // A local (non-static) logger is created inside this function to avoid static destruction problems
-        LOCAL_LOGGER( slog_ind_factory_rem, "indexed_factory_remove");
+        LOGGER( slog_ind_factory_rem, "indexed_factory_remove");
         LTRACE( slog_ind_factory_rem, "Removing indexed_factory for class " << a_index << " from " << this );
         /*
 #ifndef NDEBUG
@@ -353,7 +353,7 @@ namespace scarab
     void indexed_factory< XIndexType, XBaseType, void >::register_class( const XIndexType& a_index, const base_registrar< XBaseType >* a_registrar )
     {
         // A local (non-static) logger is created inside this function to avoid static initialization order problems
-        LOCAL_LOGGER( slog_ind_factory_reg, "indexed_factory_register");
+        LOGGER( slog_ind_factory_reg, "indexed_factory_register");
 
         std::unique_lock< std::mutex > t_lock( this->f_factory_mutex );
         FactoryCIt it = fMap->find(a_index);
@@ -377,7 +377,7 @@ namespace scarab
     void indexed_factory< XIndexType, XBaseType, void >::remove_class(const XIndexType& a_index )
     {
         // A local (non-static) logger is created inside this function to avoid static destruction problems
-        LOCAL_LOGGER( slog_ind_factory_rem, "indexed_factory_remove");
+        LOGGER( slog_ind_factory_rem, "indexed_factory_remove");
         LTRACE( slog_ind_factory_rem, "Removing indexed_factory for class " << a_index << " from " << this );
 //#ifndef NDEBUG
 //        if( ELevel::eTrace >= f_global_threshold )