fix(newm-chain): STUD-499 newm-chain hang in kogmios shutdown#43
Merged
AndrewWestberg merged 1 commit intomasterfrom Sep 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Kogmios shutdown hang issue (STUD-499) by removing blocking await calls for receive and send operations during WebSocket closure. The fix allows the client to properly shutdown without getting stuck waiting for operations to complete.
- Removes blocking
receiveClose.await()andsendClose.await()calls from the shutdown process - Re-enables a previously disabled test case with updated transaction data
- Updates various dependencies to newer versions
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/io/newm/kogmios/ClientImpl.kt | Removes blocking await calls during WebSocket closure to fix shutdown hang |
| src/test/kotlin/io/newm/kogmios/protocols/txsubmit/TxSubmitTest.kt | Re-enables test case and updates transaction test data |
| buildSrc/src/main/kotlin/Versions.kt | Updates dependency versions for various libraries |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle version to 9.1.0 |
| gradlew | Updates Gradle wrapper script to use jar execution |
| gradlew.bat | Updates Windows Gradle wrapper script to use jar execution |
| .github/workflows/ktlint.yml | Updates ktlint version in CI workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a9f9f5b to
d5a03a6
Compare
d5a03a6 to
e280634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.