Release SELinux labels on error in init function. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of an upstream fix for: opencontainers/selinux@fd7b61c Currently if we have an error in the options, we will leak and allocated SELinux label. This change will release on error. Also return the mountlabel, even if the user specifies to disable SELinux separation. This keeps other containers from being able to look at this privileged containers content, as well makeing sure all content has a label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of an upstream fix for:
opencontainers/selinux@fd7b61c
Currently if we have an error in the options, we will leak and allocated
SELinux label. This change will release on error.
Also return the mountlabel, even if the user specifies to disable SELinux separation. This keeps other containers from being able to look at this privileged
containers content, as well makeing sure all content has a label.
This is in conjunction with projectatomic/docker#370; while the leak isn't present as
runcitself doesn't call this function as often asdockerddoes, I thought it good to include.