Skip to content

Add sigstore verification for registry.access.redhat.com #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wshanks wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Add sigstore verification for registry.access.redhat.com #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions system_files/shared/etc/containers/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
"type": "signedBy",
"keyType": "GPGKeys",
"keyPath": "/etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release"
},
{
"type": "sigstoreSigned",
"keyPath": "/etc/pki/sigstore/SIGSTORE-redhat-release3",
"signedIdentity": {
"type": "matchRepository"
}
}
Comment on lines +14 to 21
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In policy.json, the list of requirements for a specific registry scope is evaluated as a logical AND. By adding the sigstoreSigned requirement while retaining the existing signedBy (GPG) requirement, you are requiring that images satisfy both verification methods.

Since the PR description states that Bluefin LTS does not include the GPG key at /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release, the signedBy check will continue to fail even if the sigstore signature is valid. Furthermore, this change makes the policy stricter for all other systems: any system that currently has the GPG key but lacks the new sigstore key will now fail to pull images from this registry because both signatures are now mandatory.

To achieve the goal of allowing sigstore verification on systems without the GPG key, you should likely replace the GPG requirement with the Sigstore one, as policy.json does not natively support 'OR' logic within a single requirement list. Additionally, consider if registry.redhat.io (line 23) requires a similar update for consistency.

],
"registry.redhat.io": [
Expand Down