Skip to content

fix(motd): guard against double display on GNOME OS / freedesktop-sdk base #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
castrojo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(motd): guard against double display on GNOME OS / freedesktop-sdk base #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions system_files/shared/etc/profile.d/ublue-motd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#!/usr/bin/env bash

# Guard against double-sourcing: /etc/profile and /etc/bashrc both source
# profile.d on GNOME OS / freedesktop-sdk based images (unlike Fedora which
# guards /etc/bashrc with shopt -q login_shell). Same pattern as BLING_SOURCED.
[ "${UBLUE_MOTD_SHOWN:-0}" -eq 1 ] && return 0
export UBLUE_MOTD_SHOWN=1
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The use of export for the UBLUE_MOTD_SHOWN variable will cause the MOTD to be suppressed in all subshells (including nested login shells) because the variable is inherited by child processes. Furthermore, if the desktop environment sources profile.d during session startup, this variable could be exported to the entire graphical session, preventing the MOTD from appearing in any terminal. Since the issue involves double-sourcing within the same shell process initialization, a local shell variable is sufficient and avoids these side effects. This also aligns with the BLING_SOURCED pattern mentioned in the PR description, which does not use export.

Suggested change
export UBLUE_MOTD_SHOWN=1
UBLUE_MOTD_SHOWN=1


[ ! -e "$HOME"/.config/no-show-user-motd ] && ublue-motd
Loading