Skip to content

feat(deps): add tealdeer (tldr) v1.8.1#116

Open
axel-kaliff wants to merge 2 commits intoprojectbluefin:mainfrom
axel-kaliff:feat/add-tealdeer
Open

feat(deps): add tealdeer (tldr) v1.8.1#116
axel-kaliff wants to merge 2 commits intoprojectbluefin:mainfrom
axel-kaliff:feat/add-tealdeer

Conversation

@axel-kaliff
Copy link
Copy Markdown

Summary

  • Add tealdeer v1.8.1
  • Pre-built musl-linked binaries for x86_64 and aarch64
  • Installs as /usr/bin/tldr with bash, zsh, and fish shell completions

Details

Follows the same BuildStream packaging pattern as glow, gum, and fzf:

  • Arch-dispatching stack element (tealdeer.bst)
  • Shared install config (.inc)
  • Per-arch manual elements using kind: remote with filename: (tealdeer publishes standalone binaries, not tarballs)

All source SHA256 hashes verified against the official GitHub release.

Testing Done

  • Local build: Yes (just build — element built and cached successfully)
  • Tested on system: Yes (booted VM via just show-me-the-future, confirmed tldr binary present)

Note

Users will need to run tldr --update on first use to download the page cache.


This PR was formatted and proof-checked by Claude Code.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the tealdeer utility, a tldr client, into the system. It ensures that the tool is available across different architectures (x86_64 and aarch64) by leveraging pre-built musl-linked binaries. The implementation adheres to existing BuildStream packaging conventions, providing a consistent approach for adding new dependencies and includes necessary shell completions for user convenience.

Highlights

  • New Dependency Added: Added tealdeer v1.8.1, a fast tldr client, to the system dependencies.
  • Multi-Architecture Support: Included pre-built musl-linked binaries for both x86_64 and aarch64 architectures.
  • Installation and Completions: The tldr binary is installed at /usr/bin/tldr, along with bash, zsh, and fish shell completions.
  • Consistent Packaging Pattern: The packaging follows the established BuildStream pattern used for other tools like glow, gum, and fzf, including arch-dispatching stack elements, shared install configs, and per-arch manual elements for remote binaries.
Changelog
  • elements/bluefin/deps.bst
    • Added bluefin/tealdeer/tealdeer.bst to the list of core dependencies.
  • elements/bluefin/tealdeer/tealdeer-aarch64.bst
    • Created a new BuildStream element to define the remote sources for the aarch64 tealdeer binary and its associated shell completion files (bash, zsh, fish).
  • elements/bluefin/tealdeer/tealdeer-x86_64.bst
    • Created a new BuildStream element to define the remote sources for the x86_64 tealdeer binary and its associated shell completion files (bash, zsh, fish).
  • elements/bluefin/tealdeer/tealdeer.bst
    • Created a new BuildStream stack element that dispatches to the correct architecture-specific tealdeer element (x86_64 or aarch64) based on the build environment.
  • elements/bluefin/tealdeer/tealdeer.inc
    • Created a new BuildStream include file (.inc) that specifies common build dependencies and defines the installation commands for the tealdeer binary and its shell completions into the appropriate system paths.
Activity
  • The author performed a local build using just build, confirming the element built and cached successfully.
  • System testing was conducted by booting a VM via just show-me-the-future to confirm the tldr binary was present.
  • The pull request was formatted and proof-checked by Claude Code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds tealdeer as a new dependency, which is a great addition. The packaging follows the existing pattern for similar tools. I've left a few suggestions to improve the maintainability of the new BuildStream elements by reducing code duplication. Specifically, I've suggested moving common sources to the .inc file and consolidating the install commands for better readability.

Comment thread elements/bluefin/tealdeer/tealdeer-aarch64.bst
Comment thread elements/bluefin/tealdeer/tealdeer-x86_64.bst
Comment thread elements/bluefin/tealdeer/tealdeer.inc
Comment thread elements/bluefin/tealdeer/tealdeer.inc
Pre-built musl binaries for x86_64 and aarch64 with bash/zsh/fish
shell completions. Installs as /usr/bin/tldr.
@castrojo
Copy link
Copy Markdown
Contributor

I'll get to this soon, sorry been focusing on the pipeline!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants