feat(brew): switch brew tarball to ublue-os/brew releases#193
Draft
dylanmtaylor wants to merge 1 commit intoprojectbluefin:mainfrom
Draft
feat(brew): switch brew tarball to ublue-os/brew releases#193dylanmtaylor wants to merge 1 commit intoprojectbluefin:mainfrom
dylanmtaylor wants to merge 1 commit intoprojectbluefin:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Homebrew tarball source to the ublue-os/brew repository and introduces a Renovate configuration to automate future updates. Critical issues were identified regarding the use of placeholder checksums (all zeros) for both x86_64 and aarch64 architectures, which will lead to build failures. Furthermore, the Renovate regex for version matching should be adjusted to support optional 'v' prefixes to prevent potential automation breakage.
| "/elements/bluefin/brew-tarball\\.bst$/" | ||
| ], | ||
| "matchStrings": [ | ||
| "url:\\s*github_files:(?<depName>ublue-os/brew)/releases/download/(?<currentValue>\\d+\\.\\d+\\.\\d+)/homebrew-[a-z0-9_]+\\.tar\\.zst\\n\\s+ref:\\s*(?<currentDigest>[a-f0-9]{64})" |
There was a problem hiding this comment.
The regex for currentValue (\d+\.\d+\.\d+) does not account for a potential v prefix in the version string. If the ublue-os/brew repository uses v-prefixed tags (e.g., v5.1.5), Renovate will update the version in the file to include the v, but will then fail to match it in subsequent runs because the regex is too restrictive. Consider allowing an optional v prefix to make the automation more robust.
"url:\\s*github_files:(?<depName>ublue-os/brew)/releases/download/(?<currentValue>v?\\d+\\.\\d+\\.\\d+)/homebrew-[a-z0-9_]+\\.tar\\.zst\\n\\s+ref:\\s*(?<currentDigest>[a-f0-9]{64})"
Depends on ublue-os/brew#14 to publish tarballs. Refs are placeholders until the first release is cut.
dylanmtaylor
force-pushed
the
feat/brew-from-ublue-os
branch
from
f56192b to
e24f026
Compare
castrojo
added a commit
to castrojo/dakota
that referenced
this pull request
Apr 13, 2026
Replaces batched tracking with per-element PRs so reviewers see exactly what changed. Adds tracking for fzf, glow, gum, gtk4-layer-shell, efibootmgr, and caffeine. Removes dead 1password steps (PR projectbluefin#206). Rewrites brew-tarball for ublue-os/brew releases (aligns with PR projectbluefin#193). Removes auto-merge; team will manually merge updates. Restores --force-with-lease throughout. Assisted-by: Claude Sonnet 4.6
castrojo
added a commit
to castrojo/dakota
that referenced
this pull request
Apr 13, 2026
Replaces batched tracking with per-element PRs so reviewers see exactly what changed. Adds tracking for fzf, glow, gum, gtk4-layer-shell, efibootmgr, and caffeine. Removes dead 1password steps (PR projectbluefin#206). Rewrites brew-tarball for ublue-os/brew releases (aligns with PR projectbluefin#193). Removes auto-merge; team will manually merge updates. Restores --force-with-lease throughout. PR titles for git_repo elements now include old -> new ref for context. Tarball PR titles use "vOLD -> vNEW" version format. Fix: gtk4-layer-shell version extraction regex was too greedy. Assisted-by: Claude Sonnet 4.6
castrojo
added a commit
to castrojo/dakota
that referenced
this pull request
Apr 13, 2026
Replaces batched tracking with per-element PRs so reviewers see exactly what changed. Adds tracking for fzf, glow, gum, gtk4-layer-shell, efibootmgr, and caffeine. Removes dead 1password steps (PR projectbluefin#206). Rewrites brew-tarball for ublue-os/brew releases (aligns with PR projectbluefin#193). Removes auto-merge; team will manually merge updates. Restores --force-with-lease throughout. PR bodies now include Renovate-style table with source link, version bump, changelog link, and compare URL. git_repo PRs include parsed version from ref and commit-to-commit compare link. Tarball PRs include direct release and compare links for each package. Existing PRs are updated in-place (gh pr edit) rather than close+create to avoid race conditions. Fix: gtk4-layer-shell version regex was greedy. Assisted-by: Claude Sonnet 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches brew-tarball.bst from the dead ublue-os/packages tarballs to ublue-os/brew releases, per Jorge's request on #164 to keep brew consistent across Bluefin variants.
Depends on ublue-os/brew#14 to start publishing release tarballs. Refs are placeholders until the first release is cut.
Also adds a renovate rule to auto-track new ublue-os/brew releases.